Thread Chain Code Review

Code review of envoy/thread-chain-impl conducted by gpt-5.3-chat-latest via the ask tool.

Review file: /tmp/thread_chain_review.txt

Critical bugs found (fixed)

Missing f-string: '\n\n[Headers only — use add_emails with Quick-ID #{i}...]' — the {i} was a literal string, not interpolated. Appeared twice in call_llm. LLM would receive '#i' literally.
_new_emails_fetched detection: used 'new_emails' in dir() hack which is fragile and newly wrong after refactor. Fixed: initialise new_emails=[] and _upgrades_done=0 before the block; use bool(new_emails) or bool(_upgrades_done) for idle detection.
Cache key normalization: .strip('<>') strips ALL leading/trailing angle brackets — e.g. '<foo@bar>>' would give 'foo@bar>' with only one stripped. Fixed: check startswith/endswith and strip exactly once.
Silent exception swallowing in thread discovery: except Exception: pass hides auth failures, broken folders, disconnects. Fixed: log at DEBUG level.
Ancestor sort by date is wrong: email Date headers can skew, be rewritten by mailing lists, etc. References header already has the correct order (oldest-first). Fixed: use reversed(candidate_mids) for ordering; date sort only for bundle-note extras.

Folder search explosion: 15 ancestors × N folders = many IMAP searches. Performance issue, not correctness.
IMAP fetch response parsing: data[0] assumption may break with servers returning multiple responses. Currently works with Dovecot.
Continuation + thread cache duplication: gathered_emails from continuation could duplicate thread ancestors. Noted for future.
Message-ID search quoting: rare edge case with malformed IDs containing quotes.

IMAP IDLE implementation: handles continuation, timeout, BYE, socket timeout reset — called 'correct and robust'.
Architecture overall: thread chain before LLM call, header-only with upgrade, in-place mutation for Quick-ID stability, idle pressure, continuation checkpointing, structured JSON schema with strict mode, phase-owned models — all called 'excellent design decisions'.
Design improvement suggestion: use SEARCH OR HEADER Message-ID / References to find replies not in the header chain (future enhancement).